Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep-alive include will also cache anonymous components #6938

Closed
PanJiaChen opened this issue Oct 27, 2017 · 4 comments
Closed

keep-alive include will also cache anonymous components #6938

PanJiaChen opened this issue Oct 27, 2017 · 4 comments
Labels
bug

Comments

@PanJiaChen
Copy link

Version

2.5.2

Reproduction link

https://jsfiddle.net/L613xva0/13/

Steps to reproduce

triggle the route

What is expected?

the second route component not be cached

What is actually happening?

the second route component be cached

this demo tow router-view component both have name, the result is right ,
but in this demo, the second route have no name ,but also be cached

The match is first checked on the component’s own name option, then its local registration name (the key in the parent’s components option) if the name option is not available. Anonymous components cannot be matched against.

<keep-alive :include="cachePages">
  <router-view></router-view>
</keep-alive>

when l keep-alive router-view , every anonymous component page will be cached , i don't think is reasonable.
@lf541512 lf541512 mentioned this issue Oct 29, 2017
Closed
@PanJiaChen PanJiaChen mentioned this issue Oct 30, 2017
Closed
8 tasks
cuteyumiko pushed a commit to cuteyumiko/vue that referenced this issue Nov 1, 2017
fix:vuejs#6938
cb94ec7
@cuteyumiko cuteyumiko mentioned this issue Nov 2, 2017
Closed
12 tasks
@yyx990803 yyx990803 added the bug label Nov 17, 2017
rocka added a commit to Rocket1184/electron-netease-cloud-music that referenced this issue Nov 20, 2017
@rocka
renderer: [App] keep-alive every page-* compo
f7e0ad4 
* see vuejs/vue#6938
@yuu2lee4
Copy link

yuu2lee4 commented Nov 20, 2017 •
edited

@yyx990803 Now keep-alive will not cache any anonymous components without include prop,it's a bug or a break change?

@devinRex
Copy link

devinRex commented Nov 20, 2017 •
edited

The same as @yuu2lee4.

You can see the reproduction in the console panel of this link https://jsfiddle.net/tqfc2edq/

The vue version 2.5.6, and you can see without "include", all anonymous components can't cahce. only mounted , without activated.

@yyx990803
Copy link
Member

Fixed in a23b913

lovelope pushed a commit to lovelope/vue that referenced this issue Feb 1, 2018
@yyx990803 @lovelope
fix: keep-alive should not cache anonymous components
8e9e93c 
This only happens if the component is returned by a intermediate
functional or abstract component, e.g. <router-view>. Fix vuejs#6938.
f2009 pushed a commit to f2009/vue that referenced this issue Jan 25, 2019
@yyx990803
fix: keep-alive should not cache anonymous components
17e9fc3 
This only happens if the component is returned by a intermediate
functional or abstract component, e.g. <router-view>. Fix vuejs#6938.
@maksnester
Copy link

@yyx990803 but what if I need to cache anonymous component, how can I do that? There is no way? Why not to stick with the key passed to it? For example for that case I would expect this component working under keep-alive:
image

But it doesn't. Because it has no name.

aJean pushed a commit to aJean/vue that referenced this issue Aug 19, 2020
@yyx990803 @aJean
fix: keep-alive should not cache anonymous components
636eab4 
This only happens if the component is returned by a intermediate
functional or abstract component, e.g. <router-view>. Fix vuejs#6938.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@yyx990803 @maksnester @devinRex @yuu2lee4 @PanJiaChen